txsizes: count change output in estimating tx size #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in estimating transaction size, the number of transaction outputs sometimes was calculated one less than actual since change output was not counted; this commit makes sure that it's counted when it exists.
Roasbeef
requested changes
Apr 20, 2022
There was a problem hiding this comment.
Great fix!
Only final ask here is a test case that reproduces the size divergence and shows that this PR fixes things. It's clear from the diff that if we added a change output that it wouldn't be accounted for, but ideally we can have that assertion locked in at the test level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the estimation of transaction size, there is an uncommon scenario in which the required space for serializing the count of outputs is calculated wrong since the change output is not counted in the count of outputs.
The source of the problem is just an unused variable which this PR fixes it.